change: update pytorch version#857
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
left a comment
laurenyu
left a comment
There was a problem hiding this comment.
add the new version to here as well: https://github.com/aws/sagemaker-python-sdk/blame/master/README.rst#L207
| from __future__ import absolute_import | ||
|
|
||
| PYTORCH_VERSION = '0.4' | ||
| PYTORCH_VERSION = '1.1.0' |
There was a problem hiding this comment.
note the comment for this variable. We stopped updating it because doing so could break existing workflows.
There was a problem hiding this comment.
Thanks for calling this out! I've reverted it to 0.4
There was a problem hiding this comment.
but it's been changed back to 1.1.0 again?
There was a problem hiding this comment.
My bad, the branch got multiple updates over the time, and I got missed this when I resolve conflicts. Thanks for pointing this out.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
left a comment
laurenyu
left a comment
There was a problem hiding this comment.
I don't think this should just have the "doc" prefix as there is a code change that's part of this PR.
| from __future__ import absolute_import | ||
|
|
||
| PYTORCH_VERSION = '0.4' | ||
| PYTORCH_VERSION = '1.1.0' |
There was a problem hiding this comment.
but it's been changed back to 1.1.0 again?
chuyang-deng
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
closed per favor of #947 |
5 participants
Issue #, if available:
Description of changes:
Update PyTorch default version to 1.1.0 and documentation.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.