Skip to content

Add typing information for some processors#3214

Closed
MatthewCaseres wants to merge 1 commit into
aws:masterfrom
MatthewCaseres:master
Closed

Add typing information for some processors#3214
MatthewCaseres wants to merge 1 commit into
aws:masterfrom
MatthewCaseres:master

Conversation

@MatthewCaseres
Copy link
Copy Markdown

@MatthewCaseres MatthewCaseres commented Jul 6, 2022 •
edited
Loading

Issue #, if available: #3213

Description of changes: Add types to classes inheriting from FrameworkProcessor and the run method.

Testing done: Have not tested, changes are only types. I am not sure what it would mean to test a type annotation, if you could provide guidance on this, please do.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I'm not sure what you would want for testing the addition of type annotations

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: cf0d18b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: cf0d18b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: cf0d18b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: cf0d18b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: cf0d18b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@vikas0203 vikas0203 requested review from a team, claytonparnell and trajanikant and removed request for a team November 23, 2022 21:31
trajanikant
trajanikant reviewed Dec 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@trajanikant trajanikant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: cf0d18b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: cf0d18b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant
trajanikant reviewed Dec 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: cf0d18b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: cf0d18b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: cf0d18b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: cf0d18b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: cf0d18b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala mufaddal-rohawala requested a review from a team as a code owner December 20, 2022 00:31
@trajanikant
Copy link
Copy Markdown
Contributor

trajanikant commented Mar 28, 2023

@MatthewCaseres Can you resolve the conflicts and get back with some updates on this?
If not we would close this and you can get back with a new PR..

@MatthewCaseres
Copy link
Copy Markdown
Author

MatthewCaseres commented Mar 28, 2023

I'll give it another go this weekend.

@MatthewCaseres
Copy link
Copy Markdown
Author

MatthewCaseres commented Apr 2, 2023

Hey I ended up not having time and am going to close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claytonparnell claytonparnell Awaiting requested review from claytonparnell claytonparnell was automatically assigned from aws/sagemaker-ml-frameworks

1 more reviewer

@trajanikant trajanikant trajanikant left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@trajanikant trajanikant

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MatthewCaseres @sagemaker-bot @trajanikant @vikas0203