Skip to content

deprecate: Remove deprecated argument s3_data_distribution_type#3064

Merged
shreyapandit merged 2 commits into
aws:masterfrom
keerthanvasist:dep
May 3, 2022
Merged

deprecate: Remove deprecated argument s3_data_distribution_type#3064
shreyapandit merged 2 commits into
aws:masterfrom
keerthanvasist:dep

Conversation

@keerthanvasist
Copy link
Copy Markdown
Contributor

@keerthanvasist keerthanvasist commented Apr 12, 2022 •
edited
Loading

Description of changes:
Remove deprecated argument s3_data_distribution_type. We have already given enough warning time for customers to stop using this parameter. Besides, the deprecation warning has removed the DataConfig parameter from the docs. In order to resolve that, and complete the deprecation, we are removing the parameter s3_data_distribution_type.

Testing done:
Unit tests passed.

Merge Checklist

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Apr 12, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: bb45474
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #3064 (626430b) into master (57d4763) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3064      +/-   ##
==========================================
- Coverage   89.60%   89.52%   -0.08%     
==========================================
  Files        1043      199     -844     
  Lines       86746    17171   -69575     
==========================================
- Hits        77728    15373   -62355     
+ Misses       9018     1798    -7220
Impacted Files Coverage Δ
src/sagemaker/clarify.py 95.41% <ø> (-0.06%) ⬇️
...b/python3.8/site-packages/sagemaker/mxnet/model.py
...es/sagemaker/cli/compatibility/v2/modifiers/tfs.py
...3.7/site-packages/sagemaker/wrangler/processing.py
....9/site-packages/sagemaker/huggingface/__init__.py
...b/python3.7/site-packages/sagemaker/local/image.py
.../sagemaker/cli/compatibility/v2/modifiers/serde.py
...n3.9/site-packages/sagemaker/lineage/visualizer.py
...hon3.9/site-packages/sagemaker/pytorch/defaults.py
...7/site-packages/sagemaker/environment_variables.py
... and 836 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d4763...626430b. Read the comment docs.

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Apr 12, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: bb45474
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@keerthanvasist keerthanvasist mentioned this pull request Apr 18, 2022
Merged
8 tasks
@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Apr 19, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4eebd7b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan
ahsan-z-khan suggested changes Apr 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahsan-z-khan ahsan-z-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing on formatting and flake8. Please run the tests locally before committing. Also consider having the pre-push hook mentioned in the guide.

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: bdef1a8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: bdef1a8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: bdef1a8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: bdef1a8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: bdef1a8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 626430b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 626430b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 626430b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 626430b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 626430b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shreyapandit shreyapandit merged commit 1d151c2 into aws:master May 3, 2022
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022
@keerthanvasist @shreyapandit @jerrypeng7773
deprecate: Remove deprecated argument s3_data_distribution_type (aws#…
8001ba7 
…3064)

Co-authored-by: Shreya Pandit <[email protected]>
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 15, 2022
@keerthanvasist @shreyapandit @jerrypeng7773
deprecate: Remove deprecated argument s3_data_distribution_type (aws#…
a5e5a3c 
…3064)

Co-authored-by: Shreya Pandit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

+3 more reviewers

@shreyapandit shreyapandit shreyapandit approved these changes

@navinsoni navinsoni navinsoni approved these changes

@ahsan-z-khan ahsan-z-khan ahsan-z-khan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs contributor changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@keerthanvasist @sagemaker-bot @codecov-commenter @shreyapandit @navinsoni @ahsan-z-khan @mufaddal-rohawala