fix: gpu use p3/p2 per avail for region#2902
Merged
mufaddal-rohawala merged 1 commit intoFeb 4, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2902 +/- ##
=======================================
Coverage 89.49% 89.49%
=======================================
Files 195 195
Lines 16636 16636
=======================================
Hits 14888 14888
Misses 1748 1748 Continue to review full report at Codecov.
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shreyapandit
approved these changes
Feb 4, 2022
ahsan-z-khan
approved these changes
Feb 4, 2022
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mufaddal-rohawala
added a commit
that referenced
this pull request
Feb 4, 2022
mufaddal-rohawala
added a commit
that referenced
this pull request
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
With the recent change in #2881 to use p3.2 gpu instance types for integ tests in us-west-2. Adding appropriate checking for other regions per availability of p3.2 was missed. This pr should fix it.
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.