Add Chainer 4.1.0#278
Conversation
* Add Chainer 4.1.0 to README * Use Chainer 4.1.0 as default Chainer version * Use fixture chainer_full_version for Chainer integ tests * Bump sdk version to 1.6.0 * Modify CHANGELOG
mvsusp
left a comment
mvsusp
left a comment
There was a problem hiding this comment.
Please, remove dev from the previous release in the changelog.
I noticed that we are running all the integ tests for both versions. That can be slow. It is worth checking if all tests are necessary to run in both versions.
Thank you!
| * bug-fix: Use chainer_full_version fixture in Chainer integration tests | ||
|
|
||
| 1.5.3dev | ||
| ======== |
There was a problem hiding this comment.
Please remove the suffix dev from here.
|
Good point about the necessity of running both versions for some of the tests. I will keep both versions only for the training related tests. |
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=========================================
- Coverage 92.46% 92.4% -0.07%
=========================================
Files 49 49
Lines 3303 3303
=========================================
- Hits 3054 3052 -2
- Misses 249 251 +2
Continue to review full report at Codecov.
|
| ===== | ||
|
|
||
| * feature: Add Chainer 4.1.0 support | ||
| * bug-fix: Use chainer_full_version fixture in Chainer integration tests |
There was a problem hiding this comment.
I don't think we add test related changes in change log.
Fixed: HPO Analyze Results notebook to catch running before a best job.
5 participants
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.