Skip to content

feature: CompilationStep support for Sagemaker Pipelines#2740

Merged
mufaddal-rohawala merged 7 commits into
aws:masterfrom
ravishankar-sivaraman:feature/CompilationStep
Nov 2, 2021
Merged

feature: CompilationStep support for Sagemaker Pipelines#2740
mufaddal-rohawala merged 7 commits into
aws:masterfrom
ravishankar-sivaraman:feature/CompilationStep

Conversation

@ravishankar-sivaraman
Copy link
Copy Markdown
Contributor

@ravishankar-sivaraman ravishankar-sivaraman commented Oct 29, 2021 •
edited
Loading

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 29, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4f98141
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 29, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4f98141
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 29, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 2deab8a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 29, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: de1719e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 29, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 2deab8a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 30, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 2deab8a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 30, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: de1719e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 30, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: de1719e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shreyapandit shreyapandit requested review from jerrypeng7773 and removed request for jerrypeng7773 October 30, 2021 02:00
@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6361ad6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6361ad6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mnuyens
mnuyens reviewed Nov 1, 2021
View reviewed changes
Comment thread src/sagemaker/inputs.py
Comment thread src/sagemaker/model.py Outdated
Comment thread src/sagemaker/model.py
mufaddal-rohawala
mufaddal-rohawala reviewed Nov 1, 2021
View reviewed changes
Comment thread src/sagemaker/inputs.py
mufaddal-rohawala
mufaddal-rohawala requested changes Nov 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mufaddal-rohawala mufaddal-rohawala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor docstring comment to mention defaults and optional/required. Otherwise LGTM.

Also needed to mention adding unit/integ tests.

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 16b2e94
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jeniyat
jeniyat previously requested changes Nov 1, 2021
View reviewed changes
Comment thread src/sagemaker/workflow/steps.py
Comment thread src/sagemaker/inputs.py
@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 16b2e94
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 16b2e94
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ravishankar-sivaraman
Added Unit test.
6cf53c9 
Bug fixes and changes for review comments
mnuyens
mnuyens previously approved these changes Nov 1, 2021
View reviewed changes
@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6cf53c9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6cf53c9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Nov 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6cf53c9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Nov 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 5aa12a6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala mufaddal-rohawala dismissed jeniyat’s stale review November 2, 2021 02:31

The requested changes have been addressed

@mufaddal-rohawala mufaddal-rohawala merged commit eee1d74 into aws:master Nov 2, 2021
jeniyat
jeniyat reviewed Nov 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeniyat jeniyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

EthanShouhanCheng pushed a commit to SissiChenxy/sagemaker-python-sdk that referenced this pull request Jan 11, 2022
@ravishankar-sivaraman @navinns
@mufaddal-rohawala @jeniyat @EthanShouhanCheng
feature: CompilationStep support for Sagemaker Pipelines (aws#2740)
50f49a2 
Co-authored-by: Navin Soni <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
Co-authored-by: Jeniya Tabassum <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
staubhp pushed a commit to staubhp/sagemaker-python-sdk that referenced this pull request Feb 4, 2022
fix: Revert "feature: CompilationStep support for Sagemaker Pipelines (…
5370deb 
…aws#2740)"

This reverts commit eee1d74.
@staubhp staubhp mentioned this pull request Feb 4, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

+3 more reviewers

@jeniyat jeniyat jeniyat left review comments

@shreyapandit shreyapandit shreyapandit approved these changes

@mnuyens mnuyens mnuyens left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ravishankar-sivaraman @sagemaker-bot @shreyapandit @mnuyens @jeniyat @mufaddal-rohawala @navinns