Skip to content

fix: HuggingFace image_uri generation for inference#2730

Merged
ahsan-z-khan merged 3 commits into
aws:masterfrom
ahsan-z-khan:HF-image-uri
Oct 26, 2021
Merged

fix: HuggingFace image_uri generation for inference#2730
ahsan-z-khan merged 3 commits into
aws:masterfrom
ahsan-z-khan:HF-image-uri

Conversation

@ahsan-z-khan
Copy link
Copy Markdown
Contributor

@ahsan-z-khan ahsan-z-khan commented Oct 25, 2021

Issue #, if available:
#2700
Description of changes:
Removed hard coded container_version from HuggingFaceModel
Testing done:
unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jeniyat
jeniyat approved these changes Oct 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeniyat jeniyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 25, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ec9ecee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 25, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ec9ecee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 25, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ec9ecee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 25, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b4e7017
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 25, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b4e7017
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 26, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: b4e7017
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 26, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 1b50306
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 26, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 1b50306
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

sagemaker-bot commented Oct 26, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 1b50306
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@philschmid
Copy link
Copy Markdown
Contributor

philschmid commented Oct 26, 2021

I tested @ahsan-z-khan branch with

pip install git+https://github.com/ahsan-z-khan/sagemaker-python-sdk.git@HF-image-uri --upgrade

it used the correct image.

@ahsan-z-khan ahsan-z-khan merged commit 9c14fb3 into aws:master Oct 26, 2021
@ahsan-z-khan ahsan-z-khan deleted the HF-image-uri branch October 26, 2021 16:14
EthanShouhanCheng pushed a commit to SissiChenxy/sagemaker-python-sdk that referenced this pull request Jan 11, 2022
@ahsan-z-khan @EthanShouhanCheng
fix: HuggingFace image_uri generation for inference (aws#2730)
842a17e 
Test passed locally. Phillip also tested and worked for him.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

+1 more reviewer

@jeniyat jeniyat jeniyat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ahsan-z-khan @sagemaker-bot @philschmid @jeniyat @mufaddal-rohawala