Fix: checking stopped status when waiting for logs#185
Conversation
Fixes issue #184. Job goes into `JOB_COMPLETE` state even when it is stopped.
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=======================================
Coverage 90.68% 90.68%
=======================================
Files 38 38
Lines 2599 2599
=======================================
Hits 2357 2357
Misses 242 242
Continue to review full report at Codecov.
|
|
Hi @sshekh , I didn't notice you sent this PR for this issue, so I made my own with some unit tests (and another case we should cover): https://github.com/aws/sagemaker-python-sdk/pull/188/files Can you incorporate those changes and update this PR? Thanks! |
|
Thanks for the quick response. Since I could not cherry-pick your commits, I just copied the changes and pushed them. |
|
Hey @sshekh , EDIT: whoops, didn't realize I didn't merge that other PR in -- I'll run the tests and get this merged in. Thanks! |
Fixed: XGBoost direct marketing. Train with CSV and update markdown.
3 participants
*Issue #184 *
Job sent to
JOB_COMPLETEstate even when it is stoppedMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.