-
Notifications
You must be signed in to change notification settings - Fork 11
Feat/durablefuture allof #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
sdk/src/test/java/com/amazonaws/lambda/durable/DurableFutureTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| package com.amazonaws.lambda.durable; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.*; | ||
| import static org.mockito.Mockito.*; | ||
|
|
||
| import com.amazonaws.lambda.durable.operation.DurableOperation; | ||
| import java.util.List; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class DurableFutureTest { | ||
|
|
||
| @Test | ||
| void allOfVarargsReturnsResultsInOrder() { | ||
| var op1 = mockOperation("first"); | ||
| var op2 = mockOperation("second"); | ||
| var op3 = mockOperation("third"); | ||
|
|
||
| var future1 = new DurableFuture<>(op1); | ||
| var future2 = new DurableFuture<>(op2); | ||
| var future3 = new DurableFuture<>(op3); | ||
|
|
||
| var results = DurableFuture.allOf(future1, future2, future3); | ||
|
|
||
| assertEquals(List.of("first", "second", "third"), results); | ||
| verify(op1).get(); | ||
| verify(op2).get(); | ||
| verify(op3).get(); | ||
| } | ||
|
|
||
| @Test | ||
| void allOfListReturnsResultsInOrder() { | ||
| var op1 = mockOperation(1); | ||
| var op2 = mockOperation(2); | ||
| var op3 = mockOperation(3); | ||
|
|
||
| var futures = List.of(new DurableFuture<>(op1), new DurableFuture<>(op2), new DurableFuture<>(op3)); | ||
|
|
||
| var results = DurableFuture.allOf(futures); | ||
|
|
||
| assertEquals(List.of(1, 2, 3), results); | ||
| } | ||
|
|
||
| @Test | ||
| void allOfVarargsEmptyReturnsEmptyList() { | ||
| var results = DurableFuture.<String>allOf(); | ||
|
|
||
| assertTrue(results.isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| void allOfListEmptyReturnsEmptyList() { | ||
| var results = DurableFuture.allOf(List.<DurableFuture<String>>of()); | ||
|
|
||
| assertTrue(results.isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| void allOfSingleFutureReturnsSingleResult() { | ||
| var op = mockOperation("only"); | ||
| var future = new DurableFuture<>(op); | ||
|
|
||
| var results = DurableFuture.allOf(future); | ||
|
|
||
| assertEquals(List.of("only"), results); | ||
| } | ||
|
|
||
| @Test | ||
| void allOfPropagatesException() { | ||
| var op1 = mockOperation("first"); | ||
| @SuppressWarnings("unchecked") | ||
| DurableOperation<String> op2 = mock(DurableOperation.class); | ||
| when(op2.get()).thenThrow(new RuntimeException("Step failed")); | ||
|
|
||
| var future1 = new DurableFuture<>(op1); | ||
| var future2 = new DurableFuture<>(op2); | ||
|
|
||
| assertThrows(RuntimeException.class, () -> DurableFuture.allOf(future1, future2)); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private <T> DurableOperation<T> mockOperation(T result) { | ||
| DurableOperation<T> op = mock(DurableOperation.class); | ||
| when(op.get()).thenReturn(result); | ||
| return op; | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should restrict the futures to have the same result types. Instead, maybe we should return a future of Void?