Feature downloaddemo rework and tests - #306
Merged
tiborauer merged 13 commits intoDec 8, 2021
Merged
Conversation
Only predefined datasets can be downloaded by aa_downloaddemo: this makes it possible to test that the datasets are still available through Continuous Integration tests. No rawdatadir manipulations inside aa_downloaddemo: When using aa_downloaddemo, the input must specify exactly where the data should go. Since this function is for use in demo scripts, can require that aap.directory_conventions.rawdatadir is set to expectation of this function. And makes this function single-purpose. No aas_shell calls in aa_downloaddemo: only use Matlab provided functions, no need to use system functions. This also makes aa_downloaddemo windows compatible. Add aa_downloaddemo_datasets to hold the list of predefined datasets. This makes it easy to loop over all predefined datasets in a test. Adapt all examples that use aa_downloaddemo to use the new calling convention.
Although this tutorial is to help users set up a parameter file, adapt it so it can also run without user interaction. In order to be able to have an automated test for tutorial_1
Tests for downloaddemo and tutorial_1, also made part of aa_test list of tests
Introduce tag-based filtering in aa_test, to have more fine-grained filtering. And add tags to the use-case tests. Add a dedicated actions yml file for the non-use-case tests.
One of the demo datasets is an unzipped tar, which can give an error with untar if an incorrect file extension is specified.
Single-step install and configure, make parameter file name an env var
tiborauer
approved these changes
Nov 26, 2021
tiborauer
self-requested a review
November 26, 2021 23:26
tiborauer
requested changes
Nov 26, 2021
tiborauer
left a comment
tiborauer
left a comment
Member
There was a problem hiding this comment.
It seems the CI has overwritten one artifact with the other: https://github.com/automaticanalysis/automaticanalysis/actions/runs/1507207336
Collaborator
Author
Ah, it took me while, but i see what you mean now: test_log.txt is created three times, but since it is uploaded with the same name, only one is available at the end. Will look into it. |
So they do not overwrite each other. Also add aa_test.log artifact to use_case tests
Member
|
Thank you, @AljenU. Would it be possible to have the log for the downloaddemo_test more informative? Right now it says |
Collaborator
Author
tiborauer
approved these changes
Dec 8, 2021
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #275
Fix issue #305