Feature: dedicated user parameters creation - #302
Conversation
…to have a single source of truth
…gh xml file at the default location Add inputs to save the new file at the default location with the default filename Also ask for spm and rawdatadir locations when using the base parameter xml as seed, since those are required for a minimal-complete parameter xml file.
…rectly Use aas_create_parameter_xml to create the user parameter xml file with the default name in the default location. Additionally, update various comments in the file Final changes to complete automaticanalysis#301
| % ------------------------------------------------------------------------- | ||
| % For BIDS data, point rawdatadir at the top level BIDS directory | ||
| % (i.e., wherever you downloaded ds000114) | ||
| FULLDATAPATH = '/full/path/to/toplevelBIDS'; |
There was a problem hiding this comment.
How about using the 'aa_demo' subfolder in aap.directory_conventions.rawdatadir to avoid the need to edit this file (in the repo)?
There was a problem hiding this comment.
I have added some changes for this to the PR. Note that the next item is some rework of aa_downloaddemo, some more comment changes etc. will be added then, when the updated assumptions in aa_downloaddemo are clear.
There was a problem hiding this comment.
I think aa_downloaddemo should be rewritten according to the CI tests. We can, perhaps, ditch the aademo dataset because the SPMCh30 and the BIDS114 seem to provide a good usecase coverage.
There was a problem hiding this comment.
I am working on that. The SPMch30 is not directly ready for use, i think, so will keep the aa_demo dataset as default for now.
tutorial_1: add downloaddemo call, remove aa_close call other examples: remove aa_close call, it is not needed when aa runs successfully, as it is already part of both aa_doprocessing and aa_report
|
Been playing with aas_create_parameter_xml. I think this is a great addition. One tweak that might improve usage: Prompts are displayed in the command window when using the non-GUI option -- could we also use these as the dialog box title for the GUI option? (I believe the uiget* utilities all take a TITLE parameter). That would help the user know what files are being selected. |
For me they do show up at the top of the gui dialogs, both windows and linux: |
|
Thats... odd. Did you change userinput.m? The version I have takes the title string as varargin{3}. This is passed to "input" (for example line 49) but not to uigetfile (for example line 42). Or maybe varargin{2:end} works differently on OS X? |
For OS X it does not show a title apparently, various questions have been asked, and solutions are mainly workarounds: https://nl.mathworks.com/matlabcentral/answers/251141-uigetfile-dialogtitle-does-not-show-in-file-browser |
|
Update: This might be an OS-X glitch. If I run this example from the uigetfile help page: Nowhere in the dialog box do the words "Pick a file" appear. Oops -- looks like we posted at the same time! |
|
I guess a simple workaround would be printing vararg{3} to the command window before putting up the dialog box if ismac is true. It's not elegant, but would be easy to implement |
|
Can we, perhaps, add these examples (at least the shorter, tutorial ones) also to the tests? |
|
Can we merge this, @AljenU, or do you still work on the Mac-workaround? |
Tutorial_1 will be added to the tests when and alongside the downloaddemo rework. I have a branch almost ready with those changes, it also includes wrapping the current use case tests in a matlab unittest wrapper. Will rebase the branch and create the PR when the current two PRs are merged.
I will add it in the new PR, lets get this one in now. |
3 participants
Adapt aa_example_helloworld and related code, to form tutorial_1_aa_setup, with dedicated section to creating a user parameter xml file.
Fixes #301