Fixes to be able to run example helloworld on windows - #291
Merged
tiborauer merged 9 commits intoNov 12, 2021
Conversation
Escape backslash characters in the windows paths, to prevent them from being interpreted as special character identifiers in printf functions Fixes for issue automaticanalysis#276
The path separator is platform dependent. Also, on Windows more character values are allowed, to allow drive letters in paths Fix issue automaticanalysis#277
Related to issue automaticanalysis#288 and issue automaticanalysis#289
Fix issue automaticanalysis#266, fixes for issue automaticanalysis#264
tiborauer
approved these changes
Nov 11, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still requires that the variables in aa_example_helloworld.m itself are set to correct windows paths, and of course to have a parameter file with the correct paths.
Fix #266
Fix #277
Fix #278
Fix #284
Fix #290
Changes for #264
Changes for #276
Changes for #279
Related to #288 and #289