Skip to content

Bugfixes related to Getting started - #263

Merged
tiborauer merged 5 commits into
automaticanalysis:masterfrom
AljenU:bugfixes_getting_started
Nov 9, 2021
Merged

Bugfixes related to Getting started#263
tiborauer merged 5 commits into
automaticanalysis:masterfrom
AljenU:bugfixes_getting_started

Conversation

@AljenU

@AljenU AljenU commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

Fixes for various bugs found during Getting started.

Closes #257
Closes #258
Closes #259
Closes #260
Partially solves #261

tiborauer added a commit that referenced this pull request Oct 28, 2021
@AljenU
AljenU force-pushed the bugfixes_getting_started branch from 068b875 to fc34c95 Compare November 5, 2021 11:06
@jones-michael-s

Copy link
Copy Markdown
Collaborator

So far this passes aatest_ds000114_fmri for me.

I tested this on my local machine (OS X 10.14 and R2018b). I'm still getting up to speed on CI. It's currently using a virtual Linux machine, yes? Will we eventually want to add virtual Windows and Macs?

@tiborauer

Copy link
Copy Markdown
Member

It is possible to run CI on Windows and MacOS:
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

@tiborauer tiborauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AljenU, Did not we agree on using pathsep instead of ":" in MATLAB path?

@AljenU

AljenU commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator Author

So far this passes aatest_ds000114_fmri for me.

I tested this on my local machine (OS X 10.14 and R2018b). I'm still getting up to speed on CI. It's currently using a virtual Linux machine, yes? Will we eventually want to add virtual Windows and Macs?

Yes, we do want to add Macs and some Windows. Some notes on that, probably better to discuss that in #272

@AljenU

AljenU commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator Author

@AljenU, Did not we agree on using pathsep instead of ":" in MATLAB path?

That will be part of the Windows-compatibility changes. For this set, it is only about changes for Getting Started on Linux.

@AljenU
AljenU force-pushed the bugfixes_getting_started branch from fc34c95 to e0a07be Compare November 8, 2021 12:33
@tiborauer
tiborauer self-requested a review November 8, 2021 17:35
@tiborauer
tiborauer dismissed their stale review November 8, 2021 17:36

It will be implemented later.

@tiborauer
tiborauer merged commit 29a3109 into automaticanalysis:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants