Skip to content

CLEANUP - modulenames - #221

Merged
tiborauer merged 2 commits into
automaticanalysis:masterfrom
tiborauer:modulenames
Apr 22, 2021
Merged

CLEANUP - modulenames#221
tiborauer merged 2 commits into
automaticanalysis:masterfrom
tiborauer:modulenames

Conversation

@tiborauer

Copy link
Copy Markdown
Member

No description provided.

@tiborauer tiborauer added question cleanup Reducing clutter or ambiguity labels Feb 12, 2021
@tiborauer

Copy link
Copy Markdown
Member Author

Considering the lack of criticism as approval, I am going to merge this PR by the end of the week.

@ethanknights

Copy link
Copy Markdown
Contributor

Sounds good I think

The renaming of modules will lead to lots of manual cosmetic changes to old tasklist.xml files (e.g. Cam-CAN used a bunch of roi extraction modules throughout multiple streams for its different releases) but that's not a major issue, and I support adopting a more structured naming scheme (I am assuming these module names are more consistent than before!).

As for deleting modules. I didn't see these listed in Cam-CAN's latest tasklist, so that shouldn't cause a compatibility problem for us (perhaps they are old WIP modules anyway(?)):

aa_modules/aamod_coreg_structural2template.m
aa_modules/aamod_coregisterstructural2template.m #dupe?

@tiborauer

tiborauer commented Mar 24, 2021

Copy link
Copy Markdown
Member Author

Thanks, @ethanknights, so you are saying it is good to go?
Also, can you, please, take care of the "manual cosmetic changes" in the CBU examples?

@jones-michael-s jones-michael-s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tiborauer

Copy link
Copy Markdown
Member Author

Thank you, @jones-michael-s. I am going to merge now.

@tiborauer
tiborauer merged commit 7e60165 into automaticanalysis:master Apr 22, 2021
@tiborauer
tiborauer deleted the modulenames branch May 5, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Reducing clutter or ambiguity question

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants