added acq_details options - #211
Conversation
|
I have two rather substantial PRs ready to go after this (one includes modification of all the modeling modules, and the other is a half-dozen new modules to implement motion scrubbing). At first I though submitting these as three smaller PR was a good approach (hence this one-file PR of our BIDS tweaks) but in hindsight maybe this is a bad idea? It occurs to me I might be tripling the number of times the test suite has to get run. If there's a consensus that one big PR would make testing easier, I could do that instead. Any thoughts? |
|
Although, there are some practicality in submitting one PR, I also think independent substantial changes deserve separate PRs. |
|
I can see a few useful settings, however, it is not clear from the beginning what are the default settings. Since they are not part of the app_paremetersets. I can also see that backward compatibility is ensured by using automaticanalysis/aa_engine/aas_processBIDS.m Lines 50 to 60 in f202cef |
|
Okay, I added initialization that hopefully clarifies the defaults. Tested locally; all looks good on my end... |
This is a simple one-file PR -- I've added some processing flags to aas_processBIDS, tweaked string processing in one place to fix a bug when one event name is contained in another, and done some cosmetic clean up.