DEBUG: Fixed potentially empty string in dummylist - #185
Closed
jpeelle wants to merge 2 commits into
Closed
Conversation
With
dummylist = [];
for d=1:numdummies
dummylist=char(dummylist,fullfile('dummy_scans',[nme ext]));
end
I was ending up with the first entry in dummylist being empty, causing
the module to crash. I added an if statement to avoid concatenation on
the first dummy scan to avoid this.
Member
|
Do not you also want to update aamod_diffusionfromnifti accordingly? |
Member
Author
|
Thanks fro catching this. In fact, I think that the strvcat() used by aamod_diffusionfromnifti does not suffer from this problem, so I updated the PR so that aamod_epifromnifti does the same thing. |
Member
|
Actually, this is what I have done in my #173: https://github.com/automaticanalysis/automaticanalysis/pull/173/files#diff-d3408a83e1ce4baf274f5914584406cc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
I was ending up with the first entry in dummylist being empty, causing
the module to crash. I added an if statement to avoid concatenation on
the first dummy scan to avoid this.