Skip to content

Tibor - #151

Merged
jooh merged 31 commits into
automaticanalysis:masterfrom
tiborauer:master
Jul 30, 2018
Merged

Tibor#151
jooh merged 31 commits into
automaticanalysis:masterfrom
tiborauer:master

Conversation

@tiborauer

@tiborauer tiborauer commented Jul 20, 2018

Copy link
Copy Markdown
Member
  • standalone
  • report
  • qsub (+non DCS)
  • diffusion
  • MPM fieldmap
  • RSA - CoSMoMVPA

@jooh

jooh commented Jul 26, 2018

Copy link
Copy Markdown
Collaborator

Are you ready for me to test this?

@tiborauer

tiborauer commented Jul 26, 2018 via email

Copy link
Copy Markdown
Member Author

@jooh

jooh commented Jul 26, 2018

Copy link
Copy Markdown
Collaborator

You broke the test by cleaning up /imaging/ta02/Temp... Probably I need to make my tests a bit less dependent on hard-coded paths. :-)

Which ds114 version is the BIDS114 user script using? The full version? I downloaded the reduced nipype2017 version, but that one is missing the task you're using...

@tiborauer

tiborauer commented Jul 26, 2018 via email

Copy link
Copy Markdown
Member Author

@jooh

jooh commented Jul 27, 2018

Copy link
Copy Markdown
Collaborator

Is this a modified version of ds114? I was hoping these BIDS examples could become the core of a new set of AA tests that are truly site independent, ie do not require access to the CBU imaging system to run.

Similarly, is the 7T BIDS example an original dataset from openneuro?

@tiborauer

Copy link
Copy Markdown
Member Author

They are unmodified (on subject level and below). I only removed all but four subjects to reduce processing.

@tiborauer

Copy link
Copy Markdown
Member Author

And yes, I agree! We have already suggested that these (or the spm demo from Rik) BIDS datasets should be used for benchmarking.

@jooh

jooh commented Jul 27, 2018

Copy link
Copy Markdown
Collaborator

Cool. I have a PR coming up that makes it possible to import only a subset of subjects from a BIDS dataset, so I think we'll be able to make this completely programmatic and reproducible.

@jooh
jooh merged commit 76cfca4 into automaticanalysis:master Jul 30, 2018
@jooh

jooh commented Jul 30, 2018

Copy link
Copy Markdown
Collaborator

Looks good, all tests passed. Merging...

jones-michael-s pushed a commit to jones-michael-s/automaticanalysis that referenced this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants