Fix bug: error in last module not stopping - #136
Merged
Merged
Conversation
When an error occurs in the last module, aa did not stop. To solve I check whether current module is last module, and then set watforalljobs = true. This could also be achieved by setting waitforalljobs = true when aaq_qsub.run_all() is called.
hhentschke
pushed a commit
to hhentschke/automaticanalysis
that referenced
this pull request
Feb 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an error occurs in the last module, aa did not stop. To solve I check whether current module is last module, and then set watforalljobs = true. This could also be achieved by setting waitforalljobs = true when aaq_qsub.run_all() is called.
I have also removed some superfluous code that was changing waitforjobs back to false unnecessarily. This is no longer needed because of the way I use obj,jobinfo to check for the existence of jobs.