volumes2movie: replaced depreciated movie2avi with writeVideo - #108
Merged
Conversation
Member
|
@jones-michael-s, Would not the code crash on earlier MATLABs? Which is the earliest version of MATLAB, which has videoWriter? |
Collaborator
Author
|
Hi Tibor (that was quick!). Mathworks says writeVideo was introduced in R2010b -- I don't know if you're supporting aa before that version. I could change the code to wrap movie2avi in a try-catch and push a new version? |
Member
|
I do not think we should go back that far! THank you for checking it. |
Member
|
Could you also observe my PR, too? |
Collaborator
Author
|
I read the pull request and don't have any comments at the moment -- is there any further action I should take? |
Member
|
You could merge it, then.
Vale,
Tibor
Auer, Tibor M.D. Ph.D.
Research Fellow in MRI
Department of Psychology
Royal Holloway University of London
Egham Hill
Egham
TW20 0EX
United Kingdom
[cid:[email protected]] +44-1784-27-6594
[cid:[email protected]] [email protected]<mailto:[email protected]>
[royalhollowaylogo]<https://www.royalholloway.ac.uk/psychology/home.aspx>
From: Mike Jones [mailto:[email protected]]
Sent: 15 May 2017 15:45
To: rhodricusack/automaticanalysis <[email protected]>
Cc: Auer, Tibor <[email protected]>; State change <[email protected]>
Subject: Re: [rhodricusack/automaticanalysis] volumes2movie: replaced depreciated movie2avi with writeVideo (#108)
I read the pull request and don't have any comments at the moment -- is there any further action I should take?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#108 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEl8qZLYUgj6pIMMUs6mMjzpzzH-ggmgks5r6GT1gaJpZM4NbMPy>.
|
jooh
pushed a commit
to jooh/automaticanalysis
that referenced
this pull request
Jun 11, 2020
merged new processBIDS properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a small change to a file in extrafunctions, mostly to try out as my first pull-request but also because the code was using a depreciated Matlab function and was crashing on us.