Repository navigation
Upgrade to Jedi 17 to support Python 3.8/3.9 - #446
Merged
Merged
Conversation
Given function `def foo(x: str = 'foo')`, `jedi.api.classes.ParamName.description` would return `param x: str = 'foo'`.
Otherwise module_name is __main__.
Newer versions of jedi support Python 3.8 and Python 3.9. Updating the bundled Jedi is not trivial as, starting from jedi 0.11, they had an external dependency (parso) which we would also have to bundle.
According to the docs, it should bundle a recent version of Python: https://docs.travis-ci.com/user/multi-os/#python-example-unsupported-languages
Member
|
Hey, thank you! Unfortunately I'm not maintaining this anymore so won't be able to test and/or publish this. @its-dhung might be able to. |
Taken from: https://github.com/JesperDramsch/keras-complex/blob/dc4b986acc69cbe7351e475882ed269381d6f594/.travis.yml#L14-L18 'python' points to Python 2.7 on macOS but points to Python 3.8 on Linux and Windows: https://docs.travis-ci.com/user/languages/python/#running-python-tests-on-multiple-operating-systems
metalogical
self-requested a review
January 19, 2021 23:32
Contributor
|
Thanks, this looks fine. Will publish shortly |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility with newer versions of Jedi (namely 0.17.x) which supports Python >=3.6.
Aside from aligning the API, I removed the bundled Jedi in favor of a system-wide (or environment wide) installation of Jedi. This should simplify the maintenance of this package. Jedi 0.11 started to add an external dependency (parso) which would make it difficult to upgrade the bundled Jedi.
Is this change welcome?
Testing Done
jedi version:
0.17.2