Repository navigation
Python 3.8 support - #436
Closed
keisuke-nakata wants to merge 1 commit into
Closed
Python 3.8 support #436keisuke-nakata wants to merge 1 commit into
keisuke-nakata wants to merge 1 commit into
Conversation
Contributor
|
Thanks for this. Without this grammar file, jump-to-definition was not working for me. |
|
Wouldn't it be better to get the updated grammar file from python docs? That's what I did on my atom and it's working fine so far. It could be also nice to include 3.9 grammar just in case. https://docs.python.org/3.8/reference/grammar.html |
Author
|
The issue which this PR tried to resolve is completely fixed by #446 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to copy current grammar file from https://raw.githubusercontent.com/python/cpython/3.8/Lib/lib2to3/Grammar.txt but it did not work well (see: #435 ), so I just
cp grammar3.7.txt grammar3.8.txt.It works pretty well on my machine.