StandardCharsets.UTF_8 instead of "UTF-8" string lookup - #49
Closed
Orbiter wants to merge 1 commit into
Closed
Conversation
serialization and performance issue)
hzalaz
force-pushed
the
master
branch
2 times, most recently
from
July 12, 2016 22:17
a60d9c9 to
111023b
Compare
adrogon
reviewed
Sep 28, 2016
adrogon
left a comment
adrogon
left a comment
There was a problem hiding this comment.
It's good. You might as well remove the Charset class import.
Contributor
|
Thanks for the PR, we enforce UTF-8 in v3 so we'll close this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should make it a bit faster