Support verification of Long[] datatype like in JWTCreator - #278
Merged
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇♂️ |
Contributor
Author
|
Ping. |
jimmyjames
self-requested a review
January 17, 2020 17:46
Contributor
|
@skjolber please rebase+fix conflicts so I can leave a review |
skjolber
force-pushed
the
verifyLongArray
branch
from
February 14, 2020 08:51
e9c3040 to
21ecf78
Compare
lbalmaceda
approved these changes
Feb 14, 2020
lbalmaceda
suggested changes
Feb 14, 2020
lbalmaceda
left a comment
lbalmaceda
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a minor javadoc problem.
lbalmaceda
approved these changes
Feb 14, 2020
Contributor
|
Thanks for this @skjolber |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Long array type so that the Verification claim types are the same as supported in JWTCreator.