Allow arbitrary byte-array for secret - #20
Merged
Conversation
This reverts commit 725e3ea.
Added new constructor to accept the array of bytes.
pose
added a commit
that referenced
this pull request
Mar 1, 2015
Allow arbitrary byte-array for secret
Contributor
|
@zerodivide1 Thanks for your contribution! In a couple of minutes it will be published in the 2.1.0 version. |
Contributor
Author
|
@pose Thank you for taking the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation does not allow using an arbitrary secret (such as a random generated secret that is base64-encoded).
The changes I have added allow using an arbitrary array of bytes as the secret.