Repository navigation
Add cache_ttl param to AsymmetricSignatureVerifier - #490
Merged
adamjmcgrath merged 1 commit intoMay 2, 2023
Merged
adamjmcgrath merged 1 commit into
adamjmcgrath merged 1 commit into
Conversation
This new, optional parameter allows setting the cache TTL for the underlying `JwksFetcher`. This allows caching the JWK set for more (or less) time than the default 600 seconds. `AsymmetricSignatureVerifier` had to be moved below `JwksFetcher` because it now references it, so the latter has to be defined earlier in the file.
adamjmcgrath
approved these changes
May 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the parameter
cache_ttltoAsymmetricSignatureVerifier. This new, optional parameter allows setting the cache TTL for the underlyingJwksFetcher. This allows caching the JWK set for more (or less) time than the default 600 seconds.AsymmetricSignatureVerifierhad to be moved belowJwksFetcherbecause it now references it, so the latter has to be defined earlier in the file.This closes #489.
References
Testing
3.11.2)Checklist