Repository navigation
Add pagination to device credentials - #300
Merged
jimmyjames merged 6 commits intoFeb 18, 2022
Merged
Conversation
jimmyjames
requested changes
Jan 10, 2022
jimmyjames
left a comment
jimmyjames
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! We should add support for the pagination params to the device credentials GET method. However, I think as currently implemented in this PR, it could be a breaking change for existing function calls using positional parameters.
fionnulak
force-pushed
the
add-pagination-to-device-credentials
branch
from
January 12, 2022 10:10
55c0e88 to
0ac5b38
Compare
jimmyjames
previously approved these changes
Jan 18, 2022
jimmyjames
approved these changes
Feb 18, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
Added two pagination parameters to the /v3/management/device-credentials get method.
References
This is in relation to #299
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist