Skip to content

Add type hints #470

Closed
Closed

Description

@Viicos

As the project is now supporting Python3.7 and greater, we could add type hints. I'd be happy to work on this if this is an option.

For reference: https://typing.readthedocs.io/en/latest/source/libraries.html

Tracked PRs:

Activity

  1. added
    feature requestA feature has been asked for or suggested by the community
    on Jan 24, 2023
  2. adamjmcgrath commented on Jan 26, 2023

    @adamjmcgrath
    Contributor

    Hi @Viicos - thanks for the offer

    We'd be happy to look at a PR, we may choose to limit the completeness of the types depending on the maintenance overhead. (eg typing the arguments required for getting a client by id, great - typing the whole response payload for every request to the management api, not maintainable for us right now)

  3. Viicos commented on Jan 26, 2023

    @Viicos
    ContributorAuthor

    Yes this is understandable, I'll take a deep look at the repository and describe on this issue where I'll add types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestA feature has been asked for or suggested by the community

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions