Returning boolean on token validator #272

Activity

1. bisguzar

   added

   feature requestA feature has been asked for or suggested by the communityA feature has been asked for or suggested by the community

   on Apr 25, 2021
2. lbalmaceda commented on May 27, 2021

   

   lbalmaceda

   on May 27, 2021

   Last edited by lbalmaceda

   Contributor

   More actions

   Returning a boolean value would make it impossible to know what went wrong with the token verification (e.g. what check triggered the failure). The exception that is raised at least has a message describing the issue. I believe this should help while developing or debugging an app. It's probably not helpful during production, as token validation issues are typically related to a wrong configuration/setup.

   i.e. something like this

   try:
     sv = AsymmetricSignatureVerifier(jwks_url)
     tv = TokenVerifier(signature_verifier=sv, issuer=issuer, audience=client_id)
     tv.verify(id_token)
   except TokenValidationError as err:
     print err

   I think making it return the token's payload claims (if all checks passed) is more useful than returning nothing. Since that way, if you want to consume the token contents, you don't need to decode it again.
3. bisguzar commented on May 28, 2021

   

   bisguzar

   on May 28, 2021

   ContributorAuthor

   More actions

   Yes, I agree. My point was it is returning None even if all checks passed. I just updated my PR. And it's open for commits by contributors.
4. stale commented on Aug 28, 2021

   

   staleBot

   on Aug 28, 2021

   More actions

   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️
5. stale

   added

   closed:staleIssue or PR has not seen activity recentlyIssue or PR has not seen activity recently

   on Aug 28, 2021
6. stale

   closed this as completedon Sep 4, 2021