Skip to content

Commit 6f2fb92

Browse files
author
Daan Hoogland
committed
findbugs: .equals() on wrapper class
1 parent 9f8a40a commit 6f2fb92

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ public List<AclData> listACLbyNetwork(Network network){
380380
Integer port = rule.getSourcePortStart();
381381
fwCidrList = _fwCidrsDao.listByFirewallRuleId(rule.getId());
382382
if(fwCidrList != null){
383-
if(fwCidrList.size()>1 || rule.getSourcePortEnd()!=port){
383+
if (fwCidrList.size() > 1 || !rule.getSourcePortEnd().equals(port)) {
384384
continue;
385385
} else {
386386
cidr = fwCidrList.get(0).getCidr();
@@ -414,7 +414,7 @@ public List<AclData> listACLbyNetwork(Network network){
414414
Integer port = item.getSourcePortStart(); // currently BCF supports single port policy
415415
aclCidrList = _aclItemCidrsDao.listByNetworkACLItemId(item.getId());
416416
if(aclCidrList != null){
417-
if(aclCidrList.size()>1 || item.getSourcePortEnd()!=port){
417+
if (aclCidrList.size() > 1 || !item.getSourcePortEnd().equals(port)) {
418418
continue;
419419
} else {
420420
cidr = aclCidrList.get(0).getCidr();

0 commit comments

Comments
 (0)