This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Ensure APM_TEST_PACKAGES may be activated in Jasmine specs - #18984
Merged
Merged
Conversation
smashwilson
added a commit
that referenced
this pull request
Mar 28, 2019
Ensure APM_TEST_PACKAGES may be activated in Jasmine specs
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix
Identify the Bug
Part of the solution to #18983.
Description of the Change
If the test runner environment of the default Jasmine runner includes
APM_TEST_PACKAGES, the packages named there will be symlinked (or, if that fails, copied) to the temporary Atom home used for the current run.Alternate Designs
@Arcanemagus spelled out some of the other alternatives in #18983. This was the quickest to implement, but should cover the immediate problem. I'm still open to doing the other suggestions (in addition to this one), especially if we hear from more people.
Possible Drawbacks
It's possible that a user has
APM_TEST_PACKAGESset in their environment, but doesn't intend to have those packages available to their test suites.If a user is running
apm installto install package prerequisites manually in CI, this will still fail.Verification Process
apm ci.language-baileywithapm install language-bailey.atom --test spec/.The specs almost all fail when run with atom 1.37.0-nightly17, or when run with this PR active on the dev resource path without
APM_TEST_PACKAGESset, but pass with this PR active andAPM_TEST_PACKAGES=language-bailey.Release Notes
APM_TEST_PACKAGES.