This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Fix "Open Folder" menu item on Windows - #18855
Merged
Merged
Conversation
1 task done
daviwil
force-pushed
the
dw-fix-open-folder
branch
from
February 15, 2019 17:55
d52982e to
bf3502c
Compare
1 task
jasonrudolph
pushed a commit
that referenced
this pull request
Mar 12, 2019
Fix "Open Folder" menu item on Windows
jasonrudolph
pushed a commit
that referenced
this pull request
Mar 12, 2019
Fix "Open Folder" menu item on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
Fixes #18835
Description of the Change
This change fixes an issue introduced by PR #17529 which caused the "File -> Open Folder" menu item to incorrectly launch the "Open File" dialog on Windows. The fix is to send the correct parameter
foldertopromptForPathToOpenwhen theapplication:open-foldercommand is executed. I've also moved the registration for these event handlers into a macOS-only code block so that they won't be activated on Windows (the original fix was only relevant to Atom instances on macOS where no windows were currently open).Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
Release Notes
N/A