Skip to content

IRSA Dust: call over https - #1069

Merged
keflavich merged 2 commits into
astropy:masterfrom
smonkewitz:irsa-dust-https
Mar 19, 2018
Merged

keflavich merged 2 commits into
astropy:masterfrom
smonkewitz:irsa-dust-https

Conversation

@smonkewitz

Copy link
Copy Markdown
Contributor

Note that besides a commit for the http to https change, this PR also includes a separate commit to ensure that files opened by the dust test cases are closed, thereby silencing quite a few pytest warnings.

@astropy-bot

astropy-bot Bot commented Mar 16, 2018

Copy link
Copy Markdown

Hi there @smonkewitz 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issue with this pull request:

  • The milestone has not been set (this can only be set by a maintainer)

Would it be possible to fix this? Thanks!

If there are any issues with this message, please report them here.

@pep8speaks

pep8speaks commented Mar 16, 2018

Copy link
Copy Markdown

Hello @smonkewitz! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on March 16, 2018 at 23:04 Hours UTC

@codecov

codecov Bot commented Mar 16, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1069 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1069   +/-   ##
=======================================
  Coverage   63.68%   63.68%           
=======================================
  Files         137      137           
  Lines       11072    11072           
=======================================
  Hits         7051     7051           
  Misses       4021     4021
Impacted Files Coverage Δ
astroquery/irsa_dust/__init__.py 100% <ø> (ø) ⬆️
astroquery/irsa_dust/core.py 81.02% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67547a6...380b976. Read the comment docs.

@keflavich

Copy link
Copy Markdown
Contributor

This is closely related to #1010

@keflavich
keflavich merged commit 6505f7a into astropy:master Mar 19, 2018
@smonkewitz
smonkewitz deleted the irsa-dust-https branch March 19, 2018 17:18
@bsipocz bsipocz added this to the v0.3.8 milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants