IRSA Dust: call over https - #1069
Conversation
|
Hi there @smonkewitz 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. I noticed the following issue with this pull request:
Would it be possible to fix this? Thanks! If there are any issues with this message, please report them here. |
|
Hello @smonkewitz! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on March 16, 2018 at 23:04 Hours UTC |
Silences numerous pytest warnings.
a3ff0e3 to
380b976
Compare
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
=======================================
Coverage 63.68% 63.68%
=======================================
Files 137 137
Lines 11072 11072
=======================================
Hits 7051 7051
Misses 4021 4021
Continue to review full report at Codecov.
|
|
This is closely related to #1010 |
Note that besides a commit for the http to https change, this PR also includes a separate commit to ensure that files opened by the dust test cases are closed, thereby silencing quite a few pytest warnings.