Remove the sep argument from _array_from_file - #6813
Merged
Merged
Conversation
Following astropy#6785, `sep` is always an empty string so no need to keep the `np.fromstring` case.
|
Hi there @saimn 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
bsipocz
approved these changes
Nov 6, 2017
bsipocz
left a comment
bsipocz
left a comment
Member
There was a problem hiding this comment.
Thanks for checking and fixing this!
Contributor
Author
|
Thanks for the reviews; got approvals so merging :) |
bsipocz
pushed a commit
that referenced
this pull request
Nov 7, 2017
Remove the sep argument from _array_from_file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #6785,
sepis always an empty string so no need to keep thenp.fromstringcase. cc @bsipocz @mhvk