Conversation
Member
|
@astrofrog - I don't think in this particular case it is possible to be more specific because the input here is a list of arbitrary user functions that can fail in arbitrary ways. So for instance I might supply a function like: In the case where the data includes a zero then a |
Member
Author
|
Ok - in that case, I'll close this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@taldcroft - while debugging an issue which ended up being due to numpy/numpy#7312, I noticed that this line was catching all exceptions, and hiding the numpy-dev issue. I think the intent was this was to make sure that string columns and other non-numerical columns didn't cause crashes, so I thought maybe we could be more specific?