Skip to content

Fix bug in parsing of frames in WCSAxes - #20480

Open
astrofrog wants to merge 4 commits into
astropy:mainfrom
astrofrog:wcsaxes-frame-parsing
Open

Fix bug in parsing of frames in WCSAxes#20480
astrofrog wants to merge 4 commits into
astropy:mainfrom
astrofrog:wcsaxes-frame-parsing

Conversation

@astrofrog

@astrofrog astrofrog commented Sep 25, 2026

Copy link
Copy Markdown
Member

Description

Testing out WCSAxes with the lsst.images SkyProjectionAstropyView APE-14 class revealed a bug in how WCSAxes identifies the coordinate frame of a WCS - specifically it did not recognize valid ways of specifying the frame including non-instantiated classes and strings.

This actually illustrates the hacky nature of how we infer frame information from WCSes and is a motivation to developing in future a standardized serialization for different frames - but this is beyond the scope of this PR.

AI Disclosure

If AI tools were used to develop this pull request, describe the tools including specific model and version, how they were used, and what content is AI generated. Otherwise enter "N/A".

Issue identified and fixed by Claude Fable 5.1, change reviewed in detail and fully understood/agreed by me

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@astrofrog astrofrog added this to the v7.2.3 milestone Sep 25, 2026
@astrofrog astrofrog added Bug visualization.wcsaxes backport-v7.2.x on-merge: backport to v7.2.x backport-v8.0.x on-merge: backport to v8.0.x labels Sep 25, 2026
@astrofrog
astrofrog requested a review from Cadair September 25, 2026 09:57
@github-actions

github-actions Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pllim
pllim reviewed Sep 25, 2026
View reviewed changes
Comment thread docs/changes/visualization/20480.bugfix.rst Outdated
@astrofrog @pllim
Add missing period
0e6b457 
Co-authored-by: P. L. Lim <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim left review comments
@larrybradley larrybradley Awaiting requested review from larrybradley larrybradley is a code owner
@Cadair Cadair Awaiting requested review from Cadair

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backport-v7.2.x on-merge: backport to v7.2.x backport-v8.0.x on-merge: backport to v8.0.x Bug visualization.wcsaxes visualization

Projects

None yet

Milestone

v7.2.3

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@astrofrog @pllim