Skip to content

Fix minerr argument to WCS with lookup table distortions - #20472

Open
astrofrog wants to merge 1 commit into
mainfrom
fix-wcs-minerr
Open

Fix minerr argument to WCS with lookup table distortions#20472
astrofrog wants to merge 1 commit into
mainfrom
fix-wcs-minerr

Conversation

@astrofrog

@astrofrog astrofrog commented Sep 23, 2026

Copy link
Copy Markdown
Member

Description

This fixes #4801 which was that the minerr keyword argument was broken under certain conditions in the WCS class. Basically, if minerr resulted in a lookup table distortion being skipped, the lookup table was accidentally passed through to WCSLIB (which doesn't understand it).

AI Disclosure

If AI tools were used to develop this pull request, describe the tools including specific model and version, how they were used, and what content is AI generated. Otherwise enter "N/A".

I worked on this fix with Claude Fable, and reviewed and agree with all the changes.

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@astrofrog astrofrog added this to the v7.2.3 milestone Sep 23, 2026
@astrofrog
astrofrog requested a review from mcara as a code owner September 23, 2026 15:40
@astrofrog astrofrog added wcs backport-v7.2.x on-merge: backport to v7.2.x backport-v8.0.x on-merge: backport to v8.0.x labels Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented Sep 23, 2026

Copy link
Copy Markdown
Member

This isn't from a fork either. Maybe your git setup is messed up?

@pllim pllim added the Bug label Sep 23, 2026
@astrofrog

astrofrog commented Sep 23, 2026

Copy link
Copy Markdown
Member Author

Yes you are right, sorry about that, I made a new clone and forgot to fix the remote 🤦‍♂️ We should make it harder to make new branches...

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcara mcara Awaiting requested review from mcara mcara is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backport-v7.2.x on-merge: backport to v7.2.x backport-v8.0.x on-merge: backport to v8.0.x Bug wcs

Projects

None yet

Milestone

v7.2.3

Development

See More

Successfully merging this pull request may close these issues.

minerr argument to WCS class broken

2 participants

@astrofrog @pllim