Skip to content

TYP/STY: allow partially typed function signatures - #20458

Merged
neutrinoceros merged 1 commit into
astropy:mainfrom
neutrinoceros:typ/allow-gradual-typing
Sep 22, 2026
Merged

neutrinoceros merged 1 commit into
astropy:mainfrom
neutrinoceros:typ/allow-gradual-typing

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

This is both the easy and important part of #20451
The goal is to pertain usage of typing.Any just to satisfy ruff by completing signatures.

AI Disclosure

N/A

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
neutrinoceros marked this pull request as ready for review September 22, 2026 09:22

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If you could follow up with a cosmo-specific tightening of these configs, that'd be appreciated. Thanks!

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

That's the plan. BTW there was a huge consensus for this PR at this morning's breakout session so, instead of waiting for everyone there to formally approve the PR, I'm going to take responsibility and merge it myself. Thanks !

@neutrinoceros
neutrinoceros merged commit f5785dc into astropy:main Sep 22, 2026
56 of 60 checks passed
@neutrinoceros
neutrinoceros deleted the typ/allow-gradual-typing branch September 22, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants