Skip to content

TYP/EXP: infer type annotation for tables with pyrefly - #20430

Draft
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:table/typ/pyrefly-infer
Draft

TYP/EXP: infer type annotation for tables with pyrefly#20430
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:table/typ/pyrefly-infer

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This experiment is meant to serve as a baseline to in my upcoming superficial review of #20276.
Most of the diff was determininistically produced in 3s with pyrefly infer astropy/tables --parameter-types=true.
In addition, I spent 20min tweaking generated import statements (mostly adding from __future__ import annotations here and there as well as if TYPE_CHECKING: guards)

AI Disclosure

N/A

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added the typing related to type annotations label Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added this to the v8.1.0 milestone Sep 17, 2026
@neutrinoceros
neutrinoceros force-pushed the table/typ/pyrefly-infer branch from 2530ff5 to 9142b3a Compare September 17, 2026 16:20
@neutrinoceros
neutrinoceros force-pushed the table/typ/pyrefly-infer branch from 9142b3a to 021721f Compare September 17, 2026 17:23
@neutrinoceros neutrinoceros mentioned this pull request Sep 22, 2026
Open
1 task

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taldcroft taldcroft Awaiting requested review from taldcroft taldcroft will be requested when the pull request is marked ready for review taldcroft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Experimental table testing typing related to type annotations unified-io

Projects

None yet

Milestone

v8.1.0

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@neutrinoceros @pllim