Skip to content

TYP: fix incorrect type-check only import statement - #20429

Open
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:table/typ/fix-units-import
Open

TYP: fix incorrect type-check only import statement#20429
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:table/typ/fix-units-import

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Description

With default (very much not strict) settings, this is the only type-check time error detected with

uv sync --extra test-all
pyrefly check astropy/table

AI Disclosure

N/A

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.0.2 milestone Sep 17, 2026
@neutrinoceros neutrinoceros added typing related to type annotations backport-v8.0.x on-merge: backport to v8.0.x labels Sep 17, 2026
@github-actions github-actions Bot added the table label Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
neutrinoceros marked this pull request as ready for review September 17, 2026 16:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taldcroft taldcroft Awaiting requested review from taldcroft taldcroft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backport-v8.0.x on-merge: backport to v8.0.x no-changelog-entry-needed table typing related to type annotations

Projects

None yet

Milestone

v8.0.2

Development

See More

Successfully merging this pull request may close these issues.

1 participant

@neutrinoceros