Skip to content

MNT: set short cache validity periods for nightly indexes - #20355

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:mnt/per-index-caching
Sep 17, 2026
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:mnt/per-index-caching

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Description

Based off #19886
Fix #20285: instead of disabling caching altogether, invalidate the cache after 12 hours, which is shorter than any nightly publication schedule I know of.

AI Disclosure

None

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.1.0 milestone Sep 10, 2026
@neutrinoceros neutrinoceros added testing Bug Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed labels Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
neutrinoceros marked this pull request as ready for review September 16, 2026 12:25

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems quite a reasonable compromise, ensuring that not every time you do a test run, the nightlies get downloaded.

I'm a bit confused about the 10 minutes, but not enough to worry...

@neutrinoceros

neutrinoceros commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor Author

The 10min on metadata is just the example from uv's docs. Metadata are much lighter than packages themselves so we typically don't need to cache them, it's just good manner to avoid DoSing PyPI :)

@pllim
pllim merged commit 5aa5b37 into astropy:main Sep 17, 2026
37 of 38 checks passed
@neutrinoceros
neutrinoceros deleted the mnt/per-index-caching branch September 17, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: disable uv caching for nightly indexes

4 participants