Skip to content

Fix AttributeError when pickling unbound DataInfo instances#19141

Open
evanshinechen wants to merge 3 commits into
astropy:mainfrom
evanshinechen:pickle-data-info
Open

Fix AttributeError when pickling unbound DataInfo instances#19141
evanshinechen wants to merge 3 commits into
astropy:mainfrom
evanshinechen:pickle-data-info

Conversation

@evanshinechen
Copy link
Copy Markdown
Contributor

@evanshinechen evanshinechen commented Jan 9, 2026 •
edited by pllim
Loading

Description

This pull request is to address an AttributeError that occurs when attempting to pickle an unbound DataInfo instance, which lacks an _attrs attribute. This bug was identified in #16352, but was never fully resolved. I have added the fix suggested by @Jerry-Ma and a regression test based on @mhvk's test case.

Example of fixed behavior:

import pickle
from astropy.utils.data_info import DataInfo
di = DataInfo()
# Previously raised AttributeError: 'DataInfo' object has no attribute '_attrs'
pickle.dumps(di)
  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions github-actions Bot added the utils label Jan 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2026

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim requested a review from mhvk January 9, 2026 14:35
@pllim pllim added this to the v7.2.1 milestone Jan 9, 2026
@pllim pllim added Bug backport-v7.2.x on-merge: backport to v7.2.x labels Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhvk mhvk Awaiting requested review from mhvk

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backport-v7.2.x on-merge: backport to v7.2.x Bug utils

Projects

None yet

Milestone

v7.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@evanshinechen @pllim