Skip to content

Ensure pyarrow.csv is available in tests (if installed)#19052

Merged
pllim merged 1 commit into
astropy:mainfrom
eerovaher:ensure-pyarrow-csv
Dec 17, 2025
Merged

Ensure pyarrow.csv is available in tests (if installed)#19052
pllim merged 1 commit into
astropy:mainfrom
eerovaher:ensure-pyarrow-csv

Conversation

@eerovaher
Copy link
Copy Markdown
Member

Description

In #19049 the parallel tests CI job failed with AttributeError: module 'pyarrow' has no attribute 'csv'. This happens if the test in question is executed before anything imports pyarrow.csv, which can happen in the parallel tests job where the test execution order is not deterministic. A simple way to prevent this problem is to import pyarrow.csv at the module level.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

A `pyarrow` test fails if it is executed before `pyarrow.csv` is
imported, which previously could happen if the tests run in parallel.
Now the `pyarrow` tests import `pyarrow.csv` at module level (if
`pyarrow` is installed`).
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@eerovaher eerovaher requested review from WilliamJamieson and neutrinoceros and removed request for WilliamJamieson and neutrinoceros December 12, 2025 18:17
Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't hurt. Thanks!

@pllim pllim merged commit 37ad526 into astropy:main Dec 17, 2025
47 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Dec 17, 2025
pllim added a commit that referenced this pull request Dec 17, 2025
…052-on-v7.2.x

Backport PR #19052 on branch v7.2.x (Ensure `pyarrow.csv` is available in tests (if installed))
@eerovaher eerovaher deleted the ensure-pyarrow-csv branch December 18, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants