Skip to content

Backport PR #17531 on branch v7.0.x (API: reintroduce private classes from astropy.visualization.lupton_rgb that were removed without deprecation in astropy 7.0.0)#17697

Merged
pllim merged 1 commit into
astropy:v7.0.xfrom
neutrinoceros:bp/17531
Jan 31, 2025

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

Manual backport for #17531

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

…e classes from `astropy.visualization.lupton_rgb` that were removed without deprecation in astropy 7.0.0)

API: reintroduce private classes from `astropy.visualization.lupton_rgb` that were removed without deprecation in astropy 7.0.0
@neutrinoceros neutrinoceros added Bug visualization Manual Backport API change PRs and issues that change an existing API, possibly requiring a deprecation period labels Jan 31, 2025
@neutrinoceros neutrinoceros added this to the v7.0.1 milestone Jan 31, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim
Copy link
Copy Markdown
Member

pllim commented Jan 31, 2025

For future reference, you can add that skip- labels as you open the PR, then we don't have to close/reopen. FYI.

@pllim pllim closed this Jan 31, 2025
@pllim pllim reopened this Jan 31, 2025
Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the backport, @timj et al. We do not do nightly wheel from backport branch though, but this will land in the next v7.0.x release. FYI.

@pllim pllim enabled auto-merge January 31, 2025 14:12
@pllim pllim merged commit b099eb9 into astropy:v7.0.x Jan 31, 2025
@neutrinoceros neutrinoceros deleted the bp/17531 branch January 31, 2025 14:29
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

For future reference, you can add that skip- labels as you open the PR

Sorry about that ! I know it, but can't be trusted with remembering it in time, apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change PRs and issues that change an existing API, possibly requiring a deprecation period Bug Manual Backport skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks visualization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants