Skip to content

MNT: Add supported Python versions to classifiers#17625

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:py-classifiers
Jan 11, 2025
Merged

MNT: Add supported Python versions to classifiers#17625
pllim merged 1 commit into
astropy:mainfrom
pllim:py-classifiers

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Jan 11, 2025

Description

This pull request is to fix #17622

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@pllim
Copy link
Copy Markdown
Member Author

pllim commented Jan 11, 2025

Do you think I also need to update release doc? 🤔

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Jan 11, 2025

I don't think so, no actionable item at release time, only when one adds or removes a version, but for removal a grep should pick this up.

@pllim pllim merged commit 1ea69e1 into astropy:main Jan 11, 2025
@pllim pllim deleted the py-classifiers branch January 11, 2025 03:03
Comment thread pyproject.toml
"Operating System :: OS Independent",
"Programming Language :: C",
"Programming Language :: Cython",
"Programming Language :: Python :: 3",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't have removed this one

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hmm. I was just following the diff of #15365 that you pointed out. That was what pyproject-fmt did, right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at the next line, it covers it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but I'm assuming classifiers are not just meant to be parsed by humans. Anyway, I can't really back this up, and I'm hoping no one ever relied on this, so, NBD

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a preference. Since pyproject-fmt was brought up in the discussion, I just thought it was less controversial to copy over what it did...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this is a matter of documentation on PyPI page... I am not aware this being used in any critical way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: add python versions to classifiers

3 participants