MNT: Add supported Python versions to classifiers#17625
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Do you think I also need to update release doc? 🤔 |
|
I don't think so, no actionable item at release time, only when one adds or removes a version, but for removal a grep should pick this up. |
| "Operating System :: OS Independent", | ||
| "Programming Language :: C", | ||
| "Programming Language :: Cython", | ||
| "Programming Language :: Python :: 3", |
There was a problem hiding this comment.
I think we shouldn't have removed this one
There was a problem hiding this comment.
Oh hmm. I was just following the diff of #15365 that you pointed out. That was what pyproject-fmt did, right?
There was a problem hiding this comment.
look at the next line, it covers it.
There was a problem hiding this comment.
It does, but I'm assuming classifiers are not just meant to be parsed by humans. Anyway, I can't really back this up, and I'm hoping no one ever relied on this, so, NBD
There was a problem hiding this comment.
I don't have a preference. Since pyproject-fmt was brought up in the discussion, I just thought it was less controversial to copy over what it did...
There was a problem hiding this comment.
AFAIK this is a matter of documentation on PyPI page... I am not aware this being used in any critical way.
Description
This pull request is to fix #17622