Skip to content

DOC: Test guide should be consistent with actual jobs we run#16185

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:test-doc-py39
Mar 11, 2024
Merged

DOC: Test guide should be consistent with actual jobs we run#16185
pllim merged 1 commit into
astropy:mainfrom
pllim:test-doc-py39

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Mar 11, 2024

Description

I think this is an oversight from PR 15603. I will just merge when RTD passes. No need for CI.

- "py310-test-image-mpl334-cov"

A direct follow-up of #15603

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

with actual jobs we run. [ci skip]
@pllim pllim added Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed labels Mar 11, 2024
@pllim pllim added this to the v6.1.0 milestone Mar 11, 2024
@github-actions github-actions Bot added the Docs label Mar 11, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since those are just examples, maybe we could bump more frankly so they stay relevant for longer ?

@pllim
Copy link
Copy Markdown
Member Author

pllim commented Mar 11, 2024

maybe we could bump more

Alas, the JSON is tied to Python version: https://github.com/astropy/astropy/tree/main/astropy/tests/figures

@pllim pllim merged commit 7c61237 into astropy:main Mar 11, 2024
@pllim pllim deleted the test-doc-py39 branch March 11, 2024 18:28
@neutrinoceros
Copy link
Copy Markdown
Contributor

oh, right ! Sorry I missed that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Docs no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants