Skip to content

TST: Install mpldev the same way as devdeps for matplotlib#15290

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:mpldev-historical-reasons
Sep 8, 2023
Merged

TST: Install mpldev the same way as devdeps for matplotlib#15290
pllim merged 1 commit into
astropy:mainfrom
pllim:mpldev-historical-reasons

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Sep 7, 2023

Description

This pull request is to address #15284 (comment)

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 7, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 7, 2023

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
Copy link
Copy Markdown
Member Author

pllim commented Sep 7, 2023

Phew we're getting a bit of a break with the ✔️ on devdeps while RCs are out... 😆

Numpy: 1.26.0rc1
Scipy: 1.12.0.dev0+1648.5495f4c
Matplotlib: 3.8.0rc1

But really this PR only affects the CircleCI job with mpldev: https://app.circleci.com/pipelines/github/astropy/astropy/17229/workflows/584c8eea-2b0d-4b72-86d2-18a2ca03d1bd/jobs/114841

Seems to pick up Matplotlib: 3.8.0rc1 that is consistent with devdeps.

I think we good here.

@pllim pllim marked this pull request as ready for review September 7, 2023 16:46
@pllim pllim requested a review from astrofrog September 7, 2023 16:46
@pllim pllim merged commit 9353c3e into astropy:main Sep 8, 2023
@pllim pllim deleted the mpldev-historical-reasons branch September 8, 2023 13:21
@pllim pllim mentioned this pull request Sep 21, 2023
1 task
@pllim pllim modified the milestones: v6.0, v5.3.4 Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants