Skip to content

DOC: Known issue for chained comparison for Quantities with dimensionless zero#15154

Merged
mhvk merged 1 commit into
astropy:mainfrom
pllim:unit-chain-eq-known-issue
Aug 11, 2023
Merged

DOC: Known issue for chained comparison for Quantities with dimensionless zero#15154
mhvk merged 1 commit into
astropy:mainfrom
pllim:unit-chain-eq-known-issue

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Aug 10, 2023

Description

This pull request is to acknowledge the limitation brought up in:

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

for Quantities with dimensionless zero.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 10, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Copy Markdown
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mhvk mhvk merged commit 6a310cc into astropy:main Aug 11, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Aug 11, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Aug 11, 2023
@pllim pllim deleted the unit-chain-eq-known-issue branch August 11, 2023 15:58
pllim added a commit that referenced this pull request Aug 11, 2023
…154-on-v5.3.x

Backport PR #15154 on branch v5.3.x (DOC: Known issue for chained comparison for Quantities with dimensionless zero)
pllim added a commit that referenced this pull request Aug 11, 2023
…154-on-v5.0.x

Backport PR #15154 on branch v5.0.x (DOC: Known issue for chained comparison for Quantities with dimensionless zero)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants