Add exptime_oir_ccd, inverse of signal_to_noise_oir_ccd#11940
Conversation
This handy inverse function calculates the exposure time to achieve a given signal to noise ratio. The implementation is straightforward: it's just the quadratic formula. I am using this in https://github.com/nasa/dorado-sensitivity, but I think astropy is a better home for this function.
|
This functionality feels more like |
|
This is ETC functionality, not observation planning. I think it could find a nice home in a hypothetical general-purpose Astropy affiliated ETC package. STScI tools like Pandeia and STIPS are probably a bit too grand. Gunagala (https://github.com/AstroHuntsman/gunagala) looks nice, but it doesn't seem to be a very active project. |
|
Isn't ETC tied to observation planning? Why would you need ETC if you don't plan on doing some observation? 😉 |
|
At least drawing on my experience with Gemini, it seems that ETC and observation planning are traditionally treated as separate tasks. You use the ETC to explore the range of acceptable observing conditions for your science targets, and then you input those constraints into the observing tool. I would guess that people often use Astroplan in a similar manner. Astroplan does not currently have any ETC capabilities. I think it would be good to have a solid and general purpose ETC with reasonable sky background models, which you can optionally couple into Astroplan. But that goes beyond the scope of this patch. |
|
👍 for this to be part of astroplan or a separate affiliated package. Getting an ETC into core would open up issues like we have with the observatory sites database. Internally it's said that maintaining such a database should not be part of astropy, but it's not communicated widely, and the contributions are coming for it. Having some ETC then the question would come up of what else should it support, etc. |
|
Hi team! Sorry for the delay. We've had a delayed PR that does similar functionality over in astroplan at astropy/astroplan#420. When we discussed this during the last astroplan GSOC, we decided ETC calculations fall within the scope of astroplan since you can envision a use case where the observer wants to dynamically schedule targets based on the S/N achievable on a given target. @lpsinger – would you mind looking to see how the astroplan PR's functionality compares with your implementation and see if that PR accomplishes the tasks you'd like to see supported in the astropy ecosystem? If so, we can resurrect that effort. I believe the test failures and rebases necessary to get that PR merged won't be too difficult. |
pllim
added
Downstream Fix Required
Close?
This comment has been minimized.
This comment has been minimized.
|
Ops... Faulty bot logic. Please ignore, sorry. |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
@pllim - Oops, the bot went rouge a bit, |
|
LoL! The "human readable time" is parsed by a third-party package. I will investigate. Sorry! Update: The bug has been fixed upstream. |
|
I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks! If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here. |
4 participants
Description
This handy inverse function calculates the exposure time to achieve a given signal to noise ratio. The implementation is straightforward: it's just the quadratic formula.
I am using this in https://github.com/nasa/dorado-sensitivity, but I think astropy is a better home for this function.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.