Skip to content

Compimagehdu inheritance#137

Merged
astrofrog merged 2 commits into
astrofrog:compimagehdu-inheritancefrom
saimn:compimagehdu-inheritance
Sep 25, 2024
Merged

Compimagehdu inheritance#137
astrofrog merged 2 commits into
astrofrog:compimagehdu-inheritancefrom
saimn:compimagehdu-inheritance

Conversation

@saimn
Copy link
Copy Markdown

@saimn saimn commented Sep 25, 2024

Hi Tom,
while looking at your latest changes I played a bit with the code and tried to remove a few things that were specific to this class.

@github-actions
Copy link
Copy Markdown

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

assert h2[0].header["DATASUM"] == "0"
assert "CHECKSUM" in h2[1].header
assert h2[1].header["CHECKSUM"] == "UAAaX40ZU97aU97Y"
assert h2[1].header["CHECKSUM"] == "ZeAbdb8aZbAabb7a"
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually reverts the checksum to the one on main. It's a quite specific case, when data and header are not modified I just return the original ._bintable instead of creating a new one.

@astrofrog
Copy link
Copy Markdown
Owner

Very nice, thanks!

@astrofrog astrofrog merged commit fe04dfd into astrofrog:compimagehdu-inheritance Sep 25, 2024
@saimn saimn deleted the compimagehdu-inheritance branch September 26, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants