Conversation
zanieb
marked this pull request as ready for review
August 3, 2026 14:13
zanieb
reviewed
Aug 3, 2026
Comment on lines
+4670
to
+4672
| /// <https://github.com/astral-sh/uv/pull/20840> began reactivating non-installable workspace | ||
| /// members during transitive dependency traversal, causing `--only-group` to install an excluded | ||
| /// project when a selected package depends on it. |
Member
There was a problem hiding this comment.
This should be in the pull body, not the doc comment here
|
Promoted to #20916. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduces astral-sh#20877, where
uv sync --only-groupinstalls the current project when a selected dependency refers back to it transitively. astral-sh#20840 began reactivating non-installable workspace members during transitive dependency traversal, causing the excluded project to be installed. Capture the existing behavior in a focused integration test so the regression can be corrected in a stacked follow-up.